- Freeradius-Devel - lists.freeradius.org

Commit report for v3.0.x branch
by announce＠freeradius.org 26 Jun '14

26 Jun '14

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== Use standard return codes Arran Cudbard-Bell@2014-06-26T23:09:51Z Files modified: * src/modules/rlm_perl/rlm_perl.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/a7c532216d0692be2906… ====== Convert binary values to octets type attributes correctly Arran Cudbard-Bell@2014-06-26T23:09:42Z Files modified: * src/modules/rlm_perl/rlm_perl.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/78027f0cc9c4e66bd947… ====== Rename vpsname to list_name Add array indexes to multivalued attributes Arran Cudbard-Bell@2014-06-26T23:09:01Z Files modified: * src/modules/rlm_perl/rlm_perl.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/d3b852d037c1e50f0376… ====== Fixup debugging and formatting in rlm_perl Arran Cudbard-Bell@2014-06-26T19:13:11Z Files modified: * src/modules/rlm_perl/rlm_perl.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/5d7ae9f11e9ff9357238… ====== Improve debug logging of rlm_perl Don't just show the attributes being copied, but also say where they are copied from/to. Herwin Weststrate (via Arran Cudbard-Bell)@2014-06-26T18:41:58Z Files modified: * src/modules/rlm_perl/rlm_perl.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/f6c27a5264b84181e058… ====== Set a timer for marking a home server dead. Closes #712 Alan T. DeKok@2014-06-26T14:33:32Z Files modified: * src/main/process.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/7bae7c8ed3ae6420c749… ====== Note recent changes Alan T. DeKok@2014-06-26T14:20:15Z Files modified: * doc/ChangeLog Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/fa93a223ca4d3d903f17… ====== Pass2 for attributes in existence checks if (&foo-LDAP-Group) { ... } Alan T. DeKok@2014-06-26T14:18:34Z Files modified: * src/main/modcall.c * src/main/parser.c * src/tests/unit/condition.txt Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/6a5bc20fb4b9b34912c3… ====== Update ChangeLog Arran Cudbard-Bell@2014-06-26T13:00:57Z Files modified: * doc/ChangeLog Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/0757441a5fbe07054806… ====== Update ChangeLog Arran Cudbard-Bell@2014-06-26T12:59:00Z Files modified: * doc/ChangeLog Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/1ef5bf11f3ed2792e98a… ====== Remove redundant includes of netinet/in.h Arran Cudbard-Bell@2014-06-26T12:55:53Z Files modified: * src/include/pcap.h * src/include/radsniff.h Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/4c704a3aa4979b61ebe9… ====== Set errno appropriately if we're building without IPv6 support and an IPv6 socket is requested Arran Cudbard-Bell@2014-06-26T12:55:40Z Files modified: * src/lib/udpfromto.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/5c21ea4dbb68c4b8a18f… ====== Define __APPLE_USER_RFC_2292 so the IPv6 socket options are exposed on OSX Arran Cudbard-Bell@2014-06-26T12:55:12Z Files modified: * configure * configure.ac * src/include/autoconf.h.in Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/e847811c96ccf11d252b… ====== Updated some required packages for Debian build With newer version of Debian (Jessie) or Ubuntu (Trusty), the packages libjson0{,-dev} are transitional packages. Prefer their replacements if they're available. Herwin Weststrate (via Arran Cudbard-Bell)@2014-06-26T12:05:11Z Files modified: * debian/control Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/c6db8a8dfb783366fbd4… ====== Use sizeof Arran Cudbard-Bell@2014-06-26T10:17:17Z Files modified: * src/lib/debug.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/b5ba959dcae956a8405a… ====== Check return code of write Arran Cudbard-Bell@2014-06-26T02:24:30Z Files modified: * src/lib/debug.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/5b36dc81adf01fc3caa1… ====== Use _fr_fault_log by default Arran Cudbard-Bell@2014-06-26T01:55:16Z Files modified: * src/lib/debug.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/683e8fed2f5aa967c3cb… ====== Only register fr_fault signal handlers if we're not running under a debugger Arran Cudbard-Bell@2014-06-26T01:55:16Z Files modified: * configure * configure.ac * src/include/autoconf.h.in * src/lib/debug.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/aa788500cad2e3d94c2e… ====== -- This commit summary was generated @2014-06-27T00:00:01Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0

Bad talloc magic value inside tls.c:sess_free_vps
by Phil Mayers 26 Jun '14

26 Jun '14

(Starting a new thread to keep mailreader depth sane) #4 0x00007f666e6ef97a in _fr_talloc_fault (reason=0x36ad408378 "Bad talloc magic value - unknown value") at src/lib/debug.c:561 #5 0x00000036ad402df1 in talloc_abort_unknown_value (ptr=<value optimized out>) at ../talloc.c:341 #6 talloc_chunk_from_ptr (ptr=<value optimized out>) at ../talloc.c:360 #7 talloc_get_name (ptr=<value optimized out>) at ../talloc.c:1153 #8 0x00000036ad4057eb in _talloc_get_type_abort (ptr=0x7f662c091dd0, name=0x7f666e714bdb "VALUE_PAIR", location=0x7f666e714bc7 "src/lib/debug.c:817") at ../talloc.c:1206 #9 0x00007f666e6f0104 in fr_verify_vp (file=0x7f666e7144f0 "src/lib/cursor.c", line=151, vp=0x7f662c091dd0) at src/lib/debug.c:817 #10 0x00007f666e6eec3f in fr_cursor_next (cursor=0x7f666a584490) at src/lib/cursor.c:151 #11 0x00007f666e70b75e in pairfree (vps=0x7f666a584508) at src/lib/valuepair.c:169 #12 0x00000000004493d6 in sess_free_vps (parent=0x7f664c0b76f0, data_ptr=0x7f662c07b140, ad=0x7f664c0b78e8, idx=0, argl=0, argp=0x0) at src/main/tls.c:1986 #13 0x00000037a0c6a68a in ?? () from /usr/lib64/libcrypto.so.10 #14 0x00000037a7c466bc in SSL_SESSION_free () from /usr/lib64/libssl.so.10 #15 0x00000037a7c445cd in SSL_free () from /usr/lib64/libssl.so.10 #16 0x000000000044624f in session_close (ssn=0x7f6644063950) at src/main/tls.c:599 At a guess, this is wrong: https://github.com/FreeRADIUS/freeradius-server/blob/v3.0.x/src/modules/rlm… ...because FR_TLS_EX_INDEX_TALLOC is used to parent the VPs paircopy'ed in: https://github.com/FreeRADIUS/freeradius-server/blob/v3.0.x/src/main/tls.c#… I spent a bit of time looking at this earlier; the lifecycle of some of these objects is really really really hard to follow, both because OpenSSL is a bit weird, and because the naming of the FR TLS stuff is used in different ways to similarly-named objects inside OpenSSL. Summary for my own notes: OpenSSL: SSL_CTX* is an OpenSSL object containing the certs/keys/settings, that creates an... SSL* is an OpenSSL "connection" i.e. an SSL handshake, that creates or uses a cached... SSL_SESSION* is a negotiated OpenSSL master key & algos FreeRADIUS tls_session_t is an OpenSSL SSL* i.e. connection plus some bits i.e. the BIOs to feed into/out of OpenSS eap_handler_t is an EAP exchange; it's keyed off State which mutates on every round trip. It contains a bunch of eap counter stuff and the tls_session_t Given that sess_free_vps() is called by OpenSSL when the session goes away, I guess we don't need to parent the cached VPs to anything; ditto the cached certs? Certainly don't want to parent the vps/certs to handler or tls_session_t; those have shorter lifetimes than SSL_SESSION* objects.

4 10

Commit report for master branch
by announce＠freeradius.org 25 Jun '14

25 Jun '14

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== Allow delayed references to attributes. Helps with #711 The short answer for the issue is to use attribute references. if (&ldap-psec-Ldap-Group == "Professors") { ... } however, using "&" would result in an error. This commit allows the "&", which will make the check work. Alan T. DeKok@2014-06-25T23:22:30Z Files modified: * src/main/parser.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/89c160239bcee33c365a… ====== Just print out what we have for debugging. Alan T. DeKok@2014-06-25T23:22:29Z Files modified: * src/main/modcall.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/814b69dbdd65f9204fb6… ====== The variable name is "max_response_timeouts" Alan T. DeKok@2014-06-25T23:22:28Z Files modified: * src/main/realms.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/3788cc6a762e09622e28… ====== Add secret "dynamic" flag to realms Which adds mutexes to the RBtree for home server add and lookup. i.e. the mutexes are likely to be contended, and therefore slower Alan T. DeKok@2014-06-25T23:22:10Z Files modified: * src/main/realms.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/06dd6bc0462078346dd2… ====== Only register signal handlers if we have a PANIC_ACTION set Arran Cudbard-Bell@2014-06-25T22:28:33Z Files modified: * src/lib/debug.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/f968b44790c1bb454a97… ====== CID #1223702 Arran Cudbard-Bell@2014-06-25T21:47:32Z Files modified: * src/modules/proto_dhcp/dhcp.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/7db1a2ab9d81ff74f3c2… ====== Merge pull request #710 from herwinw/rlm_code_t Updated return type of process_reply to rlm_rcode_t Arran Cudbard-Bell@2014-06-25T20:59:05Z Files modified: * src/modules/rlm_eap/types/rlm_eap_peap/peap.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/b7074192e25813aec31f… ====== Updated return type of process_reply to rlm_rcode_t Minor code cleanup. Herwin Weststrate@2014-06-25T20:56:37Z Files modified: * src/modules/rlm_eap/types/rlm_eap_peap/peap.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/259d9f7dd676bf869d5c… ====== Use newSVpvn so we don't SEGV on zero length values in rlm_perl Arran Cudbard-Bell@2014-06-25T18:43:16Z Files modified: * src/modules/rlm_perl/rlm_perl.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/151a12ab2871fe795955… ====== Pass through raw binary values to perl Arran Cudbard-Bell@2014-06-25T18:43:16Z Files modified: * src/modules/rlm_perl/rlm_perl.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/ed66a23c10dd62594927… ====== Add fr_abin2hex Arran Cudbard-Bell@2014-06-25T18:43:16Z Files modified: * src/include/libradius.h * src/lib/misc.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/5cfd04dc9151f15d77db… ====== Exposed realm_realm_add() For future work Alan T. DeKok@2014-06-25T18:27:25Z Files modified: * src/main/realms.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/be83f51d56973be27413… ====== Exposed realm_pool_add() For future work Alan T. DeKok@2014-06-25T18:25:43Z Files modified: * src/main/realms.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/808d5a86d8f246f3fb31… ====== Exposed realm_home_server_add() For future work Alan T. DeKok@2014-06-25T18:25:36Z Files modified: * src/include/realms.h * src/main/realms.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/e28f01bc050dca65d2a3… ====== Print out limits when opening/closing proxy sockets. Should help debug issue #680 Alan T. DeKok@2014-06-25T17:38:46Z Files modified: * src/main/process.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/bb9fc2e7fb4869354b8b… ====== Similar += fixes for other modules Arran Cudbard-Bell@2014-06-25T16:28:54Z Files modified: * src/modules/rlm_mschap/configure * src/modules/rlm_mschap/configure.ac * src/modules/rlm_sql/drivers/rlm_sql_oracle/configure * src/modules/rlm_sql/drivers/rlm_sql_oracle/configure.ac Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/1acef26487bd800f67f7… ====== Merge pull request #702 from alanbuxey/patch-4 remove the bootstrap from this VS Arran Cudbard-Bell@2014-06-25T16:22:08Z Files modified: * raddb/sites-available/tls Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/9f3c131a925ef985ad82… ====== remove the bootstrap from this VS its commented out and NOT in eap.conf Alan Buxey@2014-06-25T00:28:59Z Files modified: * raddb/sites-available/tls Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/6d3751e1812822110eec… ====== Merge pull request #704 from alanbuxey/patch-6 server should be ready on IPv6 by default Arran Cudbard-Bell@2014-06-25T16:20:53Z Files modified: * raddb/sites-available/default Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/70000990cc218db376ca… ====== server should be ready on IPv6 by default FR should be ready for IPv6 out of the box. auth/acct done. Alan Buxey@2014-06-25T00:35:31Z Files modified: * raddb/sites-available/default Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/179229c4cd7db5c6e72f… ====== Merge pull request #708 from pwdng/master Some shells don't support the '+=' concatenation operator. Arran Cudbard-Bell@2014-06-25T16:19:57Z Files modified: * src/modules/rlm_ruby/configure * src/modules/rlm_ruby/m4/ax_ruby_devel.m4 Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/f3d0a6f5ff02bf009452… ====== Some shells don't support the '+=' concatenation operator. Philippe Wooding@2014-06-25T15:46:51Z Files modified: * src/modules/rlm_ruby/configure * src/modules/rlm_ruby/m4/ax_ruby_devel.m4 Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/7ee23bc4cf105685efd2… ====== Fixed some segfaults in rlm_perl This should fix the changes of #707 Herwin Weststrate (via Arran Cudbard-Bell)@2014-06-25T16:19:28Z Files modified: * src/modules/rlm_perl/rlm_perl.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/2afe4c0fe82c76ed650c… ====== We don't actually copy... Arran Cudbard-Bell@2014-06-25T15:09:13Z Files modified: * src/modules/rlm_perl/rlm_perl.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/a67d265bc31a79cdeb69… ====== Do something sane for converting FreeRADIUS values to Kamelschewine. Fixes #707 Apparently Spracheschewine means porcupine Arran Cudbard-Bell@2014-06-25T15:04:11Z Files modified: * src/modules/rlm_perl/rlm_perl.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/8f039b7873c420f4bb1a… ====== Add fr_cursor_next_peek Arran Cudbard-Bell@2014-06-25T14:59:55Z Files modified: * src/include/libradius.h * src/lib/cursor.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/80898737f2b51876e336… ====== Formatting Arran Cudbard-Bell@2014-06-25T14:59:44Z Files modified: * src/lib/valuepair.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/d2eadfb6125bb2ed2086… ====== Populate DHCP-Paramter-Request-List values dynamically Arran Cudbard-Bell@2014-06-25T13:52:39Z Files modified: * src/modules/proto_dhcp/rlm_dhcp.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/e4bbd9abd1ae9996b7f6… ====== Remove param documentation from all connection callbacks Arran Cudbard-Bell@2014-06-25T13:07:02Z Files modified: * src/modules/rlm_ldap/ldap.c * src/modules/rlm_rest/rest.c * src/modules/rlm_yubikey/validate.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/3a52caf2674fea7cad7b… ====== Doxygen is stupid, so delete doxygen comments. It keeps complaining that "ctx" isn't documented. Fine. Go away. Alan T. DeKok@2014-06-25T13:04:01Z Files modified: * src/modules/rlm_krb5/krb5.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/fbf459a1ca2ff807f276… ====== Use NULL for talloc ctx in EAP It's safer Alan T. DeKok@2014-06-25T13:03:56Z Files modified: * src/modules/rlm_eap/libeap/eap_tls.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/e03387d39fcebf6d0c8f… ====== Fix spurious soft asserts Fixes #706 Arran Cudbard-Bell@2014-06-25T12:58:41Z Files modified: * src/lib/valuepair.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/d57481d385f079a0da00… ====== -- This commit summary was generated @2014-06-26T00:00:01Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0

Commit report for v3.0.x branch
by announce＠freeradius.org 25 Jun '14

25 Jun '14

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== Allow delayed references to attributes. Helps with #711 The short answer for the issue is to use attribute references. if (&ldap-psec-Ldap-Group == "Professors") { ... } however, using "&" would result in an error. This commit allows the "&", which will make the check work. Alan T. DeKok@2014-06-25T23:20:19Z Files modified: * src/main/parser.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/64b01c2622b6e54eb1d0… ====== Just print out what we have for debugging. Alan T. DeKok@2014-06-25T22:33:22Z Files modified: * src/main/modcall.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/664b61978715c6a30baa… ====== The variable name is "max_response_timeouts" Alan T. DeKok@2014-06-25T22:33:22Z Files modified: * src/main/realms.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/f90e9e33dfab480a8eb3… ====== Only register signal handlers if we have a PANIC_ACTION set Arran Cudbard-Bell@2014-06-25T22:28:43Z Files modified: * src/lib/debug.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/15c399cdcdc8da2fc716… ====== CID #1223702 Arran Cudbard-Bell@2014-06-25T21:47:38Z Files modified: * src/modules/proto_dhcp/dhcp.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/821eb3af74eefcff5dc4… ====== Updated return type of process_reply to rlm_rcode_t Minor code cleanup. Herwin Weststrate (via Arran Cudbard-Bell)@2014-06-25T21:00:41Z Files modified: * src/modules/rlm_eap/types/rlm_eap_peap/peap.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/d4a66591b584dd2226de… ====== Add secret "dynamic" flag to realms Which adds mutexes to the RBtree for home server add and lookup. i.e. the mutexes are likely to be contended, and therefore slower Alan T. DeKok@2014-06-25T19:05:29Z Files modified: * src/main/realms.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/575083672d7c7e434fb9… ====== Use newSVpvn so we don't SEGV on zero length values in rlm_perl Arran Cudbard-Bell@2014-06-25T18:43:02Z Files modified: * src/modules/rlm_perl/rlm_perl.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/7332e7ccce7c43b46729… ====== Add fr_abin2hex Arran Cudbard-Bell@2014-06-25T18:43:02Z Files modified: * src/include/libradius.h * src/lib/misc.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/0fcc5a0087e3d9638d07… ====== Exposed realm_realm_add() For future work Alan T. DeKok@2014-06-25T18:18:50Z Files modified: * src/main/realms.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/d6e104867f81c096ff6b… ====== Exposed realm_pool_add() For future work Alan T. DeKok@2014-06-25T18:13:05Z Files modified: * src/main/realms.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/f9f23db10ae4c081b7ff… ====== Exposed realm_home_server_add() For future work Alan T. DeKok@2014-06-25T18:07:07Z Files modified: * src/include/realms.h * src/main/realms.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/fbc302907bd8fa933f53… ====== Print out limits when opening/closing proxy sockets. Should help debug issue #680 Alan T. DeKok@2014-06-25T17:38:16Z Files modified: * src/main/process.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/c718d351be086014206a… ====== Similar += fixes for other modules Arran Cudbard-Bell@2014-06-25T16:28:48Z Files modified: * src/modules/rlm_mschap/configure * src/modules/rlm_mschap/configure.ac * src/modules/rlm_sql/drivers/rlm_sql_oracle/configure * src/modules/rlm_sql/drivers/rlm_sql_oracle/configure.ac Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/2fd01b30f632bc1254cc… ====== remove the bootstrap from this VS its commented out and NOT in eap.conf Alan Buxey (via Arran Cudbard-Bell)@2014-06-25T16:22:43Z Files modified: * raddb/sites-available/tls Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/617ae223c21cf3ce1250… ====== server should be ready on IPv6 by default FR should be ready for IPv6 out of the box. auth/acct done. Alan Buxey (via Arran Cudbard-Bell)@2014-06-25T16:21:34Z Files modified: * raddb/sites-available/default Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/2efeaaa062dd451fffc1… ====== Some shells don't support the '+=' concatenation operator. Philippe Wooding (via Arran Cudbard-Bell)@2014-06-25T16:20:34Z Files modified: * src/modules/rlm_ruby/configure * src/modules/rlm_ruby/m4/ax_ruby_devel.m4 Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/c5de11a1a5d27bbdb980… ====== Merge pull request #709 from qnet-herwin/perl_fixes_707 Fixed some segfaults in rlm_perl Arran Cudbard-Bell@2014-06-25T16:18:56Z Files modified: * src/modules/rlm_perl/rlm_perl.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/7b8c3b7752f9fd9c6bcf… ====== Fixed some segfaults in rlm_perl This should fix the changes of #707 Herwin Weststrate@2014-06-25T16:05:49Z Files modified: * src/modules/rlm_perl/rlm_perl.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/ad6539a13ff1b4fdd3da… ====== We don't actually copy... Arran Cudbard-Bell@2014-06-25T15:09:05Z Files modified: * src/modules/rlm_perl/rlm_perl.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/0c278b04f5f60dcb5926… ====== Do something sane for converting FreeRADIUS values to Kamelschewine. Fixes #707 Apparently Spracheschewine means porcupine Arran Cudbard-Bell@2014-06-25T15:04:33Z Files modified: * src/modules/rlm_perl/rlm_perl.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/26262d6be4e1ba49b940… ====== Add fr_cursor_next_peek Arran Cudbard-Bell@2014-06-25T15:04:29Z Files modified: * src/include/libradius.h * src/lib/cursor.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/45855049e16e205e5476… ====== Formatting Arran Cudbard-Bell@2014-06-25T15:04:26Z Files modified: * src/lib/valuepair.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/6b3c07bb050d999b3000… ====== Populate DHCP-Paramter-Request-List values dynamically Arran Cudbard-Bell@2014-06-25T13:52:33Z Files modified: * src/modules/proto_dhcp/rlm_dhcp.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/56ed92736acb22f74778… ====== Remove param documentation from all connection callbacks Arran Cudbard-Bell@2014-06-25T13:07:14Z Files modified: * src/modules/rlm_ldap/ldap.c * src/modules/rlm_rest/rest.c * src/modules/rlm_yubikey/validate.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/4b91f54e459687739ed4… ====== Doxygen is stupid, so delete doxygen comments. It keeps complaining that "ctx" isn't documented. Fine. Go away. Alan T. DeKok@2014-06-25T13:03:47Z Files modified: * src/modules/rlm_krb5/krb5.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/824748760783a9e9dd26… ====== Fix spurious soft asserts Fixes #706 Arran Cudbard-Bell@2014-06-25T12:59:23Z Files modified: * src/lib/valuepair.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/6277deabd7184fcc03ac… ====== Use NULL for talloc ctx in EAP It's safer Alan T. DeKok@2014-06-25T01:29:44Z Files modified: * src/modules/rlm_eap/libeap/eap_tls.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/43f3f031128cd9fd8617… ====== -- This commit summary was generated @2014-06-26T00:00:01Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0

ldap group membership issue in 3.0.4 RC1
by Kevin Wasserman 25 Jun '14

25 Jun '14

Hello, In testing our merge of 3.0.4 RC1 it seems that rlm_ldap_groupcmp() is no longer invoked to check group membership when evaluating unlang conditionals and instead always returns FALSE. Previously, in 3.0.1, when freeradius parsed our policy.d/user-filter unlang generated (output culled from "freeradius -fxx -l stdout"): (7) ? if (control:ldap-psec-Ldap-Group == "Professors") (7) Searching for user in group "Professors" rlm_ldap (ldap-psec): Opening additional connection (7) <<details omitted>> (7) ? if (control:ldap-psec-Ldap-Group == "Professors") -> TRUE Now I never see "Searching for user in group", but rather simply: (8) ? if (control:ldap-psec-Ldap-Group == "Professors") (8) ? if (control:ldap-psec-Ldap-Group == "Professors") -> FALSE Running under gdb, a breakpoint set on rlm_ldap_groupcmp is never hit. Any ideas? Kevin Wasserman Painless Security, LLC --- This email is free from viruses and malware because avast! Antivirus protection is active. http://www.avast.com

2 1

Commit report for master branch
by announce＠freeradius.org 24 Jun '14

24 Jun '14

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== Add in rad_virtual_server() which is now required for libeap Alan T. DeKok@2014-06-24T23:23:03Z Files modified: * src/modules/rlm_eap/radeapclient.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/54d36f0bd981d0dc0679… ====== Glue channel bindings into the TTLS code Alan T. DeKok@2014-06-24T20:43:59Z Files modified: * src/modules/rlm_eap/types/rlm_eap_ttls/ttls.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/5e630991fd0106676fa8… ====== Channel binding encode/decoder and process functions Alan T. DeKok@2014-06-24T20:43:58Z Files modified: * raddb/sites-available/channel_bindings * src/modules/rlm_eap/libeap/all.mk * src/modules/rlm_eap/libeap/eap_chbind.c * src/modules/rlm_eap/libeap/eap_chbind.h * src/modules/rlm_eap/libeap/eapcommon.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/d81d8fce405706dc038f… ====== Attributes and definitions fo channel bindings Alan T. DeKok@2014-06-24T20:43:57Z Files modified: * share/dictionary.freeradius.internal * share/dictionary.ukerna * src/include/radius.h Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/a604037a4840ae9ab902… ====== Move debug messages into rad_virtual_server To remove duplication Alan T. DeKok@2014-06-24T20:43:56Z Files modified: * src/main/auth.c * src/modules/rlm_eap/types/rlm_eap_peap/peap.c * src/modules/rlm_eap/types/rlm_eap_tls/rlm_eap_tls.c * src/modules/rlm_eap/types/rlm_eap_ttls/ttls.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/8ed6d4872a695af9cae4… ====== Move exit functions to debug.c Arran Cudbard-Bell@2014-06-24T19:07:12Z Files modified: * src/include/libradius.h * src/lib/debug.c * src/lib/heap.c * src/lib/log.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/3478733f774f29c67f0e… ====== Merge pull request #700 from mcnewton/rlm_files make "this file is processed in order" more clear... Arran Cudbard-Bell@2014-06-24T18:32:40Z Files modified: * raddb/mods-config/files/authorize Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/f21725fd5449da109b89… ====== Rebuild all the configure scripts to use the new FR_SMART_INCLUDE Arran Cudbard-Bell@2014-06-24T17:48:04Z Files modified: * src/modules/rlm_counter/configure * src/modules/rlm_eap/configure * src/modules/rlm_eap/types/rlm_eap_ikev2/configure * src/modules/rlm_eap/types/rlm_eap_pwd/configure * src/modules/rlm_eap/types/rlm_eap_sim/configure * src/modules/rlm_eap/types/rlm_eap_tnc/configure * src/modules/rlm_example/configure * src/modules/rlm_idn/configure * src/modules/rlm_ippool/configure * src/modules/rlm_ldap/configure * src/modules/rlm_mschap/configure * src/modules/rlm_opendirectory/configure * src/modules/rlm_otp/configure * src/modules/rlm_pam/configure * src/modules/rlm_perl/configure * src/modules/rlm_python/configure * src/modules/rlm_radutmp/configure * src/modules/rlm_redis/configure * src/modules/rlm_rediswho/configure * src/modules/rlm_rest/configure * src/modules/rlm_ruby/configure * src/modules/rlm_securid/configure * src/modules/rlm_smsotp/configure * src/modules/rlm_sql/configure * src/modules/rlm_sql/drivers/rlm_sql_db2/configure * src/modules/rlm_sql/drivers/rlm_sql_firebird/configure * src/modules/rlm_sql/drivers/rlm_sql_freetds/configure * src/modules/rlm_sql/drivers/rlm_sql_iodbc/configure * src/modules/rlm_sql/drivers/rlm_sql_mysql/configure * src/modules/rlm_sql/drivers/rlm_sql_oracle/configure * src/modules/rlm_sql/drivers/rlm_sql_postgresql/configure * src/modules/rlm_sql/drivers/rlm_sql_sqlite/configure * src/modules/rlm_sql/drivers/rlm_sql_unixodbc/configure * src/modules/rlm_sqlcounter/configure * src/modules/rlm_sqlhpwippool/configure * src/modules/rlm_sqlippool/configure * src/modules/rlm_unbound/configure * src/modules/rlm_unix/configure * src/modules/rlm_wimax/configure * src/modules/rlm_yubikey/configure Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/ccd4240cafa070c9fa48… ====== Extra include dirs should be specified with -isystem Arran Cudbard-Bell@2014-06-24T16:53:03Z Files modified: * src/modules/rlm_krb5/configure * src/modules/rlm_krb5/configure.ac Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/8b7ff8844b83e58063c1… ====== talloc_steal the packet after reading it Alan T. DeKok@2014-06-24T15:20:57Z Files modified: * src/main/listen.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/8cad34e6e93d4150939c… ====== Ensure packet is parented correctly Alan T. DeKok@2014-06-24T15:20:55Z Files modified: * src/main/tls_listen.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/49fe8fab478b7a75a585… ====== newvector should be a bool Arran Cudbard-Bell@2014-06-24T14:19:29Z Files modified: * src/include/libradius.h * src/lib/radius.c * src/lib/tcp.c * src/main/command.c * src/main/detail.c * src/main/listen.c * src/main/process.c * src/main/radclient.c * src/main/radsniff.c * src/main/tls_listen.c * src/main/unittest.c * src/main/util.c * src/modules/proto_dhcp/dhcp.c * src/modules/proto_dhcp/dhcpclient.c * src/modules/proto_vmps/vqp.c * src/modules/rlm_eap/radeapclient.c * src/modules/rlm_replicate/rlm_replicate.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/7a99ed8c9c9421ab5aed… ====== Print which packet in the request failed validation Arran Cudbard-Bell@2014-06-24T13:57:12Z Files modified: * src/main/util.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/5937933a3a2a39d219e3… ====== Can't parent ARP packets off the listener Arran Cudbard-Bell@2014-06-24T13:55:10Z Files modified: * src/modules/proto_arp/proto_arp.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/363616c1b9cd52ba4ce6… ====== Minor connection API fixes Arran Cudbard-Bell@2014-06-24T12:11:55Z Files modified: * src/include/connection.h * src/modules/rlm_ldap/ldap.c * src/modules/rlm_yubikey/validate.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/50440cf5907b1959f148… ====== Print out TAG_ANY attributes correctly When attributes are inserted into the lists they should have their tag set to TAG_NONE if their tag was previously TAG_ANY Arran Cudbard-Bell@2014-06-24T11:18:27Z Files modified: * src/lib/print.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/46a48c3f4fe866604242… ====== -- This commit summary was generated @2014-06-25T00:00:02Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0

Commit report for v3.0.x branch
by announce＠freeradius.org 24 Jun '14

24 Jun '14

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== Add in rad_virtual_server() which is now required for libeap Alan T. DeKok@2014-06-24T23:22:56Z Files modified: * src/modules/rlm_eap/radeapclient.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/fc18d0d30e9bb47c84aa… ====== Add support for Vendor Specific Suboptions (RFC 4243) Add support for array type suboptions Allow terminating suboption and padding suboption Add dictionary attributes for a many more DHCP RFCs Arran Cudbard-Bell@2014-06-24T22:44:22Z Files modified: * share/dictionary.dhcp * share/dictionary.rfc4679 * src/include/dhcp.h * src/lib/dict.c * src/modules/proto_dhcp/dhcp.c * src/modules/proto_dhcp/rlm_dhcp.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/be0abff24856908a8b81… ====== Glue channel bindings into the TTLS code Alan T. DeKok@2014-06-24T20:43:39Z Files modified: * src/modules/rlm_eap/types/rlm_eap_ttls/ttls.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/3ba2973efff4d8bd00b5… ====== Channel binding encode/decoder and process functions Alan T. DeKok@2014-06-24T20:43:39Z Files modified: * raddb/sites-available/channel_bindings * src/modules/rlm_eap/libeap/all.mk * src/modules/rlm_eap/libeap/eap_chbind.c * src/modules/rlm_eap/libeap/eap_chbind.h * src/modules/rlm_eap/libeap/eapcommon.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/13ed1e0b63bc4813f94c… ====== Attributes and definitions fo channel bindings Alan T. DeKok@2014-06-24T20:43:39Z Files modified: * share/dictionary.freeradius.internal * share/dictionary.ukerna * src/include/radius.h Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/18b3994c7c554614466e… ====== Move debug messages into rad_virtual_server To remove duplication Alan T. DeKok@2014-06-24T20:43:39Z Files modified: * src/main/auth.c * src/modules/rlm_eap/types/rlm_eap_peap/peap.c * src/modules/rlm_eap/types/rlm_eap_tls/rlm_eap_tls.c * src/modules/rlm_eap/types/rlm_eap_ttls/ttls.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/f04cfd980f4495e01cd6… ====== Move exit functions to debug.c Arran Cudbard-Bell@2014-06-24T19:07:18Z Files modified: * src/include/libradius.h * src/lib/debug.c * src/lib/heap.c * src/lib/log.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/c4250d10861259c2c45c… ====== Merge pull request #700 from mcnewton/rlm_files make "this file is processed in order" more clear... Arran Cudbard-Bell@2014-06-24T18:32:01Z Files modified: * raddb/mods-config/files/authorize Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/5fe27ca3b231593ae511… ====== make "this file is processed in order" more clear... Matthew Newton@2014-06-24T16:35:52Z Files modified: * raddb/mods-config/files/authorize Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/366cbcd55b7823f13e7e… ====== Fix build when building on OSX, using non standard libssl, and a non standard version of clang/gcc (or a < OSX 10.9 version of clang/gcc) Arran Cudbard-Bell@2014-06-24T17:43:37Z Files modified: * src/modules/rlm_counter/configure * src/modules/rlm_counter/configure.ac * src/modules/rlm_eap/configure * src/modules/rlm_eap/configure.ac * src/modules/rlm_eap/types/rlm_eap_ikev2/configure * src/modules/rlm_eap/types/rlm_eap_ikev2/configure.ac * src/modules/rlm_eap/types/rlm_eap_pwd/configure * src/modules/rlm_eap/types/rlm_eap_sim/configure * src/modules/rlm_eap/types/rlm_eap_tnc/configure * src/modules/rlm_eap/types/rlm_eap_tnc/configure.ac * src/modules/rlm_example/configure * src/modules/rlm_example/configure.ac * src/modules/rlm_idn/configure * src/modules/rlm_idn/configure.ac * src/modules/rlm_ippool/configure * src/modules/rlm_ippool/configure.ac * src/modules/rlm_krb5/configure * src/modules/rlm_krb5/configure.ac * src/modules/rlm_ldap/configure * src/modules/rlm_mschap/configure * src/modules/rlm_opendirectory/configure * src/modules/rlm_otp/configure * src/modules/rlm_pam/configure * src/modules/rlm_perl/configure * src/modules/rlm_python/configure * src/modules/rlm_radutmp/configure * src/modules/rlm_redis/configure * src/modules/rlm_redis/configure.ac * src/modules/rlm_rediswho/configure * src/modules/rlm_rediswho/configure.ac * src/modules/rlm_rest/configure * src/modules/rlm_rest/configure.ac * src/modules/rlm_ruby/configure * src/modules/rlm_securid/configure * src/modules/rlm_securid/configure.ac * src/modules/rlm_smsotp/configure * src/modules/rlm_sql/configure * src/modules/rlm_sql/configure.ac * src/modules/rlm_sql/drivers/rlm_sql_db2/configure * src/modules/rlm_sql/drivers/rlm_sql_db2/configure.ac * src/modules/rlm_sql/drivers/rlm_sql_firebird/configure * src/modules/rlm_sql/drivers/rlm_sql_firebird/configure.ac * src/modules/rlm_sql/drivers/rlm_sql_freetds/configure * src/modules/rlm_sql/drivers/rlm_sql_freetds/configure.ac * src/modules/rlm_sql/drivers/rlm_sql_iodbc/configure * src/modules/rlm_sql/drivers/rlm_sql_iodbc/configure.ac * src/modules/rlm_sql/drivers/rlm_sql_mysql/configure * src/modules/rlm_sql/drivers/rlm_sql_mysql/configure.ac * src/modules/rlm_sql/drivers/rlm_sql_oracle/configure * src/modules/rlm_sql/drivers/rlm_sql_oracle/configure.ac * src/modules/rlm_sql/drivers/rlm_sql_postgresql/configure * src/modules/rlm_sql/drivers/rlm_sql_postgresql/configure.ac * src/modules/rlm_sql/drivers/rlm_sql_sqlite/configure * src/modules/rlm_sql/drivers/rlm_sql_sqlite/configure.ac * src/modules/rlm_sql/drivers/rlm_sql_unixodbc/configure * src/modules/rlm_sql/drivers/rlm_sql_unixodbc/configure.ac * src/modules/rlm_sqlcounter/configure * src/modules/rlm_sqlcounter/configure.ac * src/modules/rlm_sqlhpwippool/configure * src/modules/rlm_sqlhpwippool/configure.ac * src/modules/rlm_sqlippool/configure * src/modules/rlm_sqlippool/configure.ac * src/modules/rlm_unbound/configure * src/modules/rlm_unix/configure * src/modules/rlm_wimax/configure * src/modules/rlm_yubikey/configure * src/modules/rlm_yubikey/configure.ac Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/254f0dfedf4dc550f10e… ====== Extra include dirs should be specified with -isystem Arran Cudbard-Bell@2014-06-24T16:53:13Z Files modified: * src/modules/rlm_krb5/configure * src/modules/rlm_krb5/configure.ac Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/393752a770db16107005… ====== talloc_steal the packet after reading it Alan T. DeKok@2014-06-24T15:20:43Z Files modified: * src/main/listen.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/f0ae8d4f9c8e52146196… ====== newvector should be a bool Arran Cudbard-Bell@2014-06-24T14:57:35Z Files modified: * src/include/libradius.h * src/lib/radius.c * src/lib/tcp.c * src/main/command.c * src/main/detail.c * src/main/listen.c * src/main/process.c * src/main/radclient.c * src/main/radsniff.c * src/main/tls_listen.c * src/main/unittest.c * src/main/util.c * src/modules/proto_dhcp/dhcp.c * src/modules/proto_dhcp/dhcpclient.c * src/modules/proto_vmps/vqp.c * src/modules/rlm_eap/radeapclient.c * src/modules/rlm_replicate/rlm_replicate.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/bc2d71b74d5704b50363… ====== Ensure packet is parented correctly Alan T. DeKok@2014-06-24T14:54:48Z Files modified: * src/main/tls_listen.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/da22d5d6acdda28edb71… ====== Print which packet in the request failed validation Arran Cudbard-Bell@2014-06-24T13:57:34Z Files modified: * src/main/util.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/58ab2b135f4dd001bed0… ====== Minor connection API fixes Arran Cudbard-Bell@2014-06-24T12:12:00Z Files modified: * src/include/connection.h * src/modules/rlm_ldap/ldap.c * src/modules/rlm_yubikey/validate.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/12aca057fe2fc0ced97f… ====== Print out TAG_ANY attributes correctly When attributes are inserted into the lists they should have their tag set to TAG_NONE if their tag was previously TAG_ANY Arran Cudbard-Bell@2014-06-24T11:18:02Z Files modified: * src/lib/print.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/713a487928b48ba76add… ====== -- This commit summary was generated @2014-06-25T00:00:02Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0

master vs. v3.0.x branches
by Zenon Mousmoulas 24 Jun '14

24 Jun '14

Hi, I've noticed that master and v3.0.x mostly move in parallel but the commits are not shared. Why is that? Sorry if this has been discussed previously, I couldn't find anything. Thanks, Z.

2 1

talloc & threads in rlm_eap
by Phil Mayers 24 Jun '14

24 Jun '14

I'm wondering if we're breaking the talloc() threading restrictions in rlm_eap / main/tls.c somewhere? Specifically, I think tls_new_session can be called from multiple threads at the same time, and that calls talloc with a context of "conf" i.e. the module config, which is not per-thread. The talloc docs say each thread must use a separate context (or, presumably, lock). I wonder if this is what's triggering the corruption? Ditto cbtls_new_session (though OpenSSL locking might protect that) and I think a few other places. ( rlm_eap might be due a substantial cleanup; I find it really really hard to grasp, personally. What do people think? )

3 51

Connection API compatibility break v3.0.0-v3.0.3 and v3.0.4 onwar
by Arran Cudbard-Bell 24 Jun '14

24 Jun '14

Because of the talloc threadsafety issues we've been experiencing, the allocations in the connection pool API have had to be modified so that they're all performed from the NULL context. Many fr_connection_create callback functions allocated connection structs directly from the module's instance ctx. This was not thread safe and may have caused subtle memory corruption. The new fr_connection_create_t is passed a TALLOC_CTX allocated from the NULL ctx. The module should allocate any handle specific memory under this ctx. When the connection is destroyed the TALLOC_CTX will be freed. Modules which require additional cleanup (such as closing sockets), should add a destructor to the memory allocated under the TALLOC_CTX (not the TALLOC_CTX itself). The fr_connection_delete_t callback has been removed completely, and is no longer supported. fr_connection_create_t ---------------------- /** Create a new connection handle * * This function will be called whenever the connection pool manager needs * to spawn a new connection, and on reconnect. * * Memory should be talloced in the parent context to hold the module's * connection structure. The parent context is allocated in the NULL * context, but will be freed when fr_connection_t is freed. * * There is no delete callback, so operations such as closing sockets and * freeing library connection handles should be done by a destructor attached * to memory allocated beneath ctx. * * @note A function pointer matching this prototype must be passed * to fr_connection_pool. * * @param[in,out] ctx to allocate memory in. * @param[in] opaque pointer passed to fr_connection_pool_init. * @return NULL on error, else a connection handle. */ typedef void *(*fr_connection_create_t)(TALLOC_CTX *ctx, void *opaque); Creating rlm_ldap handles (module specific data) ------------------------------------------------ /** Close and delete a connection * * Unbinds the LDAP connection, informing the server and freeing any memory. * * @param conn to destroy. * @return always indicates success. */ static int _mod_conn_free(ldap_handle_t *conn) { if (conn->handle) ldap_unbind_s(conn->handle); return 0; } /** Create and return a new connection * * Create a new ldap connection and allocate memory for a new rlm_handle_t * * @param ctx to allocate connection handle memory in. * @param instance rlm_ldap instance. * @return A new connection handle or NULL on error. */ void *mod_conn_create(TALLOC_CTX *ctx, void *instance) { ... ldap_instance_t *inst = instance; ldap_handle_t *conn; /* * Allocate memory for the handle. */ conn = talloc_zero(ctx, ldap_handle_t); if (!conn) return NULL; talloc_set_destructor(conn, _mod_conn_free); ... #ifdef HAVE_LDAP_INITIALIZE if (inst->is_url) { DEBUG("rlm_ldap (%s): Connecting to %s", inst->xlat_name, inst->server); ldap_errno = ldap_initialize(&conn->handle, inst->server); if (ldap_errno != LDAP_SUCCESS) { LDAP_ERR("ldap_initialize failed: %s", ldap_err2string(ldap_errno)); goto error; } } else #endif ... return conn } Freeing rlm_yubikey handles (no module specific data) ----------------------------------------------------- /** Frees a ykclient handle * * @param[in] yandle rlm_yubikey_handle_t to close and free. * @return returns 0. */ static int _mod_conn_free(ykclient_handle_t **yandle) { ykclient_handle_done(yandle); return 0; } /** Creates a new connection handle for use by the FR connection API. * * Matches the fr_connection_create_t function prototype, is passed to * fr_connection_pool_init, and called when a new connection is required by the * connection pool API. * * @see fr_connection_pool_init * @see fr_connection_create_t * @see connection.c * * @param[in] ctx to allocate connection data from. * @param[in] instance configuration data. * @return connection handle or NULL if the connection failed or couldn't * be initialised. */ static void *mod_conn_create(TALLOC_CTX *ctx, void *instance) { rlm_yubikey_t *inst = instance; ykclient_rc status; ykclient_handle_t *yandle, **marker; status = ykclient_handle_init(inst->ykc, &yandle); if (status != YKCLIENT_OK) { ERROR("rlm_yubikey (%s): %s", inst->name, ykclient_strerror(status)); return NULL; } marker = talloc(ctx, ykclient_handle_t *); talloc_set_destructor(marker, _mod_conn_free); *marker = yandle; return yandle; } Arran Cudbard-Bell <a.cudbardb(a)freeradius.org> FreeRADIUS Development Team FD31 3077 42EC 7FCD 32FE 5EE2 56CF 27F9 30A8 CAA2

1 0