- Freeradius-Devel - lists.freeradius.org

v2.1.x branch renamed to v2.x.x
by Arran Cudbard-Bell 29 Oct '12

29 Oct '12

Someone was complaining about the branch name v2.1.x being confusing now were on 2.2.0. There's no point in maintaining a branch for v2.1.x because there's never going to be further development. To fixup branches in your fork: git branch -m v2.1.x v2.x.x git config branch.v2.x.x.merge refs/head/v2.x.x git push origin v2.x.x git push origin :v2.1.x -Arran

4 7

Commit report for master branch
by announce＠freeradius.org 27 Oct '12

27 Oct '12

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== More fixes to make it work with system libtool && jlibtool Alan T. DeKok@2012-10-27T17:57:19Z Files modified: * Make.inc.in * src/lib/Makefile * src/modules/rlm_eap/libeap/Makefile * src/modules/rlm_sql/drivers/rules.mak * src/modules/rules.mak Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/18d09fae538b74cfac05… ====== Try to fix "home server dead" code It was pretty horrific, and didn't make sense. This simplification seems to work Alan T. DeKok@2012-10-27T13:47:02Z Files modified: * src/include/realms.h * src/main/command.c * src/main/process.c * src/main/realms.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/8d3a825d3548f907b378… ====== Minor formatting fixes Arran Cudbard-Bell@2012-10-27T12:26:35Z Files modified: * src/modules/rlm_cache/rlm_cache.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/1a7f30764908b00527cf… ====== Merge pull request #118 from philmayers/cache-locking add locking to rlm_cache Arran Cudbard-Bell@2012-10-27T12:14:55Z Files modified: * src/modules/rlm_cache/rlm_cache.c * share/dictionary.proxim Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/0569523d3eab69bde29f… ====== add locking to rlm_cache Phil Mayers@2012-10-27T10:38:02Z Files modified: * src/modules/rlm_cache/rlm_cache.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/97b9bd5e630ad6f7ce54… ====== After running it through the formatter Alan T. DeKok@2012-10-27T10:00:36Z Files modified: * share/dictionary.proxim Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/af92d92268a8a901914d… ====== Fixes to work with system libtool Alan T. DeKok@2012-10-27T09:08:18Z Files modified: * Make.inc.in * src/modules/rlm_sql/drivers/rules.mak * src/modules/rules.mak Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/15433acd6429d37f0bff… ====== Remove last shred of libtool WARNING: don't do "autoreconf", as it adds libtool back! Instead, do "autoconf". Alan T. DeKok@2012-10-27T08:59:06Z Files modified: * aclocal.m4 * configure Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/9ffe113bbe5a3cbad511… ====== -- This commit summary was generated @2012-10-27T18:00:01Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0

Commit report for v2.1.x branch
by announce＠freeradius.org 27 Oct '12

27 Oct '12

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== Note more changes Arran Cudbard-Bell@2012-10-27T12:53:08Z Files modified: * doc/ChangeLog Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/b50a6fb10a5c1557ae43… ====== Minor formatting fixes Arran Cudbard-Bell@2012-10-27T12:27:49Z Files modified: * src/modules/rlm_cache/rlm_cache.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/e03f2af5086975b03ecc… ====== Merge pull request #117 from philmayers/cache-locking-v21x add locking to rlm_cache Arran Cudbard-Bell@2012-10-27T12:15:06Z Files modified: * src/modules/rlm_cache/rlm_cache.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/5d7188eabafc4e5e90f3… ====== add locking to rlm_cache Phil Mayers@2012-10-27T10:35:58Z Files modified: * src/modules/rlm_cache/rlm_cache.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/102534fb15f862e0d16b… ====== -- This commit summary was generated @2012-10-27T18:00:01Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0

xlat performance / "compile time" parsing?
by Phil Mayers 27 Oct '12

27 Oct '12

I recently made some changes to our FreeRADIUS logging config, inspired by Matthew Newton's creative use of linelog as discussed on the -users list. The config uses a wrapping unlang policy, along with quite a bit of conditional expansion. Since deploying it, I've noticed the CPU use of our FreeRADIUS server has jumped, at lot. Hotspot profiling with "oprofile" tells me that almost all the time is being spent inside a few critical functions: radius_xlat rad_copy_variable radius_evaluate_condition I've stared at the code for the first two a bit, and I think I understand why it's so expensive; it essentially parses the input string one character at a time, every time, and in the case of a conditional attribute, it walks over the input twice (or more). A roughly similar thing happens wth radius_evaluate_condition. This set me to wondering about some kind of parser cache. The idea would be that a string like: "var %{%{foo}:-%{%{bar}:-baz}}" ...would be parsed into some kind of linked-list / tree, like so: v[0].type = LITERAL v[0].value = "var " v[1].type = CONDITIONAL v[1].value = struct { left.type = EXPANSION left.value = "foo" right.type = CONDITIONAL right.value = struct { left.type = EXPANSION left.value = "bar" right.type = LITERAL right.value = "baz" } } The parsing would be done transparently by radius_xlat the first time it saw an input template, and cached for the lifetime of the process - though I haven't yet figured out how to do this without locking. Once parsed, the expansion function should be both very simple, and very fast. If we wanted to go even further, the EXPANSION values could be the attribute number rather than name, but I am having trouble reasoning out whether this might lead to problems with changing xlat or attribute registrations e.g. on HUP or similar. Something similar could be done for radius_evaluate_condition, except it's even easier there - only the unlang code calls uses conditions, so we can just compile it - no need to transparently convert the string. Before I embark on this to see if it helps - is this even a reasonable approach? Cheers, Phil

2 1

rlm_cache locking (or not)
by Phil Mayers 27 Oct '12

27 Oct '12

On 26/10/12 15:34, Phil Mayers wrote: > I was about to say "that worked like a charm" then radiusd segfaulted :o( > > I'll try to get a core dump. > Ugh. Horrible pointer corruption; little useful in the backtrace I'm afraid, but the various pointers were invalid by stack frame #5 #0 0x000000357f630215 in raise () from /lib64/libc.so.6 #1 0x000000357f631cc0 in abort () from /lib64/libc.so.6 #2 0x000000357f66a7fb in __libc_message () from /lib64/libc.so.6 #3 0x000000357f671ce2 in _int_free () from /lib64/libc.so.6 #4 0x000000357f67590c in free () from /lib64/libc.so.6 #5 0x00002aaaad3444ac in cache_entry_free (data=0xc00aa0) at rlm_cache.c:77 #6 0x00000031bb212eac in rbtree_delete (tree=0xbd5530, Z=0xbfd050) at rbtree.c:412 #7 0x00000031bb21302b in rbtree_deletebydata (tree=0xbd5530, data=<value optimized out>) at rbtree.c:461 #8 0x00002aaaad344465 in cache_find (inst=0xbd4eb0, request=0x2aaab8001150, key=0x41e013c0 "172.16.250.14.Stop.508aa231/dc:2b:61:b0:cd:7c/653919") at rlm_cache.c:164 #9 0x00002aaaad344652 in cache_it (instance=0xbd4eb0, request=0x2aaab8001150) at rlm_cache.c:567 #10 0x000000000041c951 in call_modsingle (component=3, c=<value optimized out>, request=0x2aaab8001150) at modcall.c:304 Looking at the code, I'm not entirely sure it's thread-safe; I don't see any locking around anything. What's to stop cache_entry_free running at the same time as the node is being accessed in another thread? Or the rbtree being corrupted? I've had to roll the change back, so I can't give more details at the moment.

3 6

Commit report for master branch
by announce＠freeradius.org 26 Oct '12

26 Oct '12

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== Use redis escape function Alan T. DeKok@2012-10-26T13:48:23Z Files modified: * src/modules/rlm_rediswho/rlm_rediswho.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/dc74102ca0d75b9e682a… ====== -- This commit summary was generated @2012-10-26T18:00:01Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0

Commit report for v2.1.x branch
by announce＠freeradius.org 26 Oct '12

26 Oct '12

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== Use redis escape function Alan T. DeKok@2012-10-26T13:46:05Z Files modified: * src/modules/rlm_rediswho/rlm_rediswho.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/6e8e5ab2510f999b68a9… ====== Note changes Alan T. DeKok@2012-10-26T10:34:23Z Files modified: * doc/ChangeLog Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/9e5960b55bc8755cff11… ====== Create threads as joinable, not detached. Stop and join all threads before detaching modules. This prevents a crash on exit where the modules are free'd before the threads stop using them. Iliya Peregoudov (via Alan T. DeKok)@2012-10-26T10:34:23Z Files modified: * src/include/radiusd.h * src/main/event.c * src/main/threads.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/fe2066fdf9d73c8dc53c… ====== -- This commit summary was generated @2012-10-26T18:00:01Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0

Commit report for master branch
by announce＠freeradius.org 25 Oct '12

25 Oct '12

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== Understand extended format attrs, too Alan T. DeKok@2012-10-25T14:04:23Z Files modified: * share/format.pl Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/35998cb0bfff03d9b203… ====== Create threads as joinable, not detached. Stop and join all threads before detaching modules. This prevents a crash on exit where the modules are free'd before the threads stop using them. Iliya Peregoudov (via Alan T. DeKok)@2012-10-25T14:04:23Z Files modified: * src/include/radiusd.h * src/main/process.c * src/main/threads.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/3758d9b1c7636571f323… ====== Add proxim dictionary Arran Cudbard-Bell@2012-10-25T11:53:55Z Files modified: * share/dictionary * share/dictionary.proxim Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/3a5534e09966af937372… ====== Pass correct arguments to memcpy Copying pointers means you pass a pointer to the pointer. Alan T. DeKok@2012-10-25T10:10:22Z Files modified: * src/modules/rlm_krb5/rlm_krb5.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/8829737fde77cbfd4677… ====== Merge branch 'master' of github.com:FreeRADIUS/freeradius-server Alan T. DeKok@2012-10-25T10:04:48Z Files modified: * raddb/policy.d/cui * src/modules/rlm_krb5/rlm_krb5.c * src/main/exec.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/ab4ab0c284b3b1754274… ====== -- This commit summary was generated @2012-10-25T18:00:01Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0

Commit report for v2.1.x branch
by announce＠freeradius.org 25 Oct '12

25 Oct '12

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== Add proxim dictionary Arran Cudbard-Bell@2012-10-25T11:55:30Z Files modified: * share/dictionary * share/dictionary.proxim Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/ea828e5d1e4734efd8ca… ====== Pass correct arguments to memcpy Copying pointers means you pass a pointer to the pointer. Alan T. DeKok (via Arran Cudbard-Bell)@2012-10-25T11:55:20Z Files modified: * src/modules/rlm_krb5/rlm_krb5.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/197af098df8c35689e9e… ====== -- This commit summary was generated @2012-10-25T18:00:01Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0

Commit report for master branch
by announce＠freeradius.org 24 Oct '12

24 Oct '12

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== Merge pull request #112 from armitasp/master Minor formatting fix. add_cui should be add-cui Arran Cudbard-Bell@2012-10-24T09:13:34Z Files modified: * raddb/policy.d/cui Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/c63f7d209bd5a3964465… ====== Minor formatting fix. add_cui should be add-cui Scott Armitage@2012-10-23T21:36:11Z Files modified: * raddb/policy.d/cui Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/00a7e0d4e51bfeab78d9… ====== -- This commit summary was generated @2012-10-24T18:00:01Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0