- Freeradius-Devel - lists.freeradius.org

SIGTERM -> SIGSEGV
by Stefan Winter 23 Oct '12

23 Oct '12

Hi, I believe this has been reported earlier and it's not very grave, but anyway: When shutting down the server normally, it will almost cleanly shut down, including "Exiting normally" in the logs, but will generate a SIGSEGV after that. So, something in the terminal cleanup seems wrong. It's not a big deal usually, because after all the process is going to die anyway. However, now with systemd, things are slightly different. systemd will watch over the return code of any PID under its responsibility and memorizes these return codes for later debugging by the admin. So these days, I'd appreciate if even during shutdown time, things are "clean". I looked through the shutdown in radiusd.c main() and spotted - I believe - two spots where things go wrong: - rcode is derived from a function, and can be an arbitrary number; and the process in the end returns rcode - 1. On failures it gets set to 2 (i.e. return 1) but on normal shutdown, it doesn't get set. I "fixed" the situation by adding a "rcode = 1" right after the "Exiting normally." This ensures that the process returns 0 once it gets to its return statement. - It never gets there; the SIGSEGV on my system is generated during the call to free_mainconfig(). Once comment that line out, I get a clean shutdown. I'm not sure this is a sane approach, it's rather a brute fix with the axe. Anyway, trivial patch below. --- freeradius-server-2.2.0/src/main/radiusd.c 2012-09-10 13:51:34.000000000 +0200 +++ freeradius-server-2.2.0-patched/src/main/radiusd.c 2012-10-12 10:14:02.136026913 +0200 @@ -416,6 +416,7 @@ rcode = 2; } else { radlog(L_INFO, "Exiting normally."); + rcode = 1; } /* @@ -448,7 +449,7 @@ /* * Free the configuration items. */ - free_mainconfig(); + /* free_mainconfig(); */ /* * Detach any modules. Greetings, Stefan Winter -- Stefan WINTER Ingenieur de Recherche Fondation RESTENA - Réseau Téléinformatique de l'Education Nationale et de la Recherche 6, rue Richard Coudenhove-Kalergi L-1359 Luxembourg Tel: +352 424409 1 Fax: +352 422473

3 4

Commit report for v2.1.x branch
by announce＠freeradius.org 23 Oct '12

23 Oct '12

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== More formatting fixes Arran Cudbard-Bell@2012-10-23T15:18:42Z Files modified: * src/modules/rlm_krb5/rlm_krb5.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/311b8c1537825d184977… ====== Improve Kerberos support when using Heimdal - Allow specifying a keytab location - Improved logging Patch obtained from Thomas Kula <kula(a)tproa.net> - Fix krb_auth parameters/casting - Use strlcpy() instead of strncpy() - Fix style issues Ryan Steinmetz (via Arran Cudbard-Bell)@2012-10-23T15:18:31Z Files modified: * src/modules/rlm_krb5/rlm_krb5.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/3864f83d95c48b4e14f6… ====== -- This commit summary was generated @2012-10-23T18:00:01Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0

Commit report for master branch
by announce＠freeradius.org 23 Oct '12

23 Oct '12

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== More formatting fixes Arran Cudbard-Bell@2012-10-23T15:16:53Z Files modified: * src/modules/rlm_krb5/rlm_krb5.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/d86daa9e572c86f3f5e2… ====== Improve Kerberos support when using Heimdal - Allow specifying a keytab location - Improved logging Patch obtained from Thomas Kula <kula(a)tproa.net> - Fix krb_auth parameters/casting - Use strlcpy() instead of strncpy() - Fix style issues Ryan Steinmetz (via Arran Cudbard-Bell)@2012-10-23T13:38:44Z Files modified: * src/modules/rlm_krb5/rlm_krb5.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/63de016e22e1d14cbc1f… ====== -- This commit summary was generated @2012-10-23T18:00:01Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0

Re: segfault
by Alan Buxey 23 Oct '12

23 Oct '12

debug log please (and upgrade, 2.1.10 is old and buggy...and has a security issue) alan

1 0

segfault
by Xavi Serra 23 Oct '12

23 Oct '12

Hi, I have an ubuntu 12.04 running with a freeradius that validates against an LDAP. Everything was OK since i installed munin for monitoring, which i assume it installed some libraries that make my freeradius crash. i get this error message freeradius[15646]: segfault at 29 ip 00007fcef673159c sp 00007fff0d2a9e98 error 4 in libc-2.15.so[7fcef66ae000+1b5000] need some light over here. thanks in advanced and sorry for my english. freeradius: FreeRADIUS Version 2.1.10 ubuntu 12.04 LTS

1 0

Commit report for master branch
by announce＠freeradius.org 22 Oct '12

22 Oct '12

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== Fixup formatting and errors in cui policy and dependencies Include sql cui queries by default, as the cuisql module won't be instantiated in the default config. Change cui_has_key value to make it clear that it should be changed. Use string (yes/no) for bool in cui_require_operator_name for consistancy, ideally the parser would pre-evaluate comparisons between literal strings, but the performance hit does not outweigh consistency. Remove spurious spaces around conditions. Literal strings should be literal (i.e. single quotes). Packet-Type is still provided by a magic xlat expension. Substitute 8 spaces for tabs (config files have same formatting rules as C src) Use outer.request:EAP-Message to check whether were in an inner or outer tunnel, should be forwards compatible. ${} values are pre-expanded, so do not require double quotes. control:Proxy-To-Realm is not a magic attribute, it's a standard attribute in the control list (even when set by rlm_realm). cui virtual module does not have xlat method, should use cuisql. Arran Cudbard-Bell@2012-10-22T11:23:07Z Files modified: * raddb/mods-available/cui * raddb/policy.d/cui * raddb/policy.d/operator-name Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/f5416720dc8d010f82b5… ====== Merge branch 'master' of github.com:FreeRADIUS/freeradius-server Arran Cudbard-Bell@2012-10-22T10:34:42Z Files modified: * raddb/mods-available/cui * raddb/policy.d/cui * raddb/sites-available/default * raddb/sites-available/inner-tunnel * src/include/libradius.h Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/9ba7b14211b87b086508… ====== Merge pull request #110 from armitasp/master Updated CUI Policy Arran Cudbard-Bell@2012-10-22T10:33:44Z Files modified: * raddb/mods-available/cui * raddb/policy.d/cui * raddb/sites-available/default * raddb/sites-available/inner-tunnel Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/a9eba18a6165ff45086d… ====== Changed sites-available/default. Documented the use of cui Scott Armitage@2012-10-21T18:49:56Z Files modified: * raddb/sites-available/default Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/9a349045b830d23be9d2… ====== Changed sites-available/inner-tunnel. Documented the use of cui Scott Armitage@2012-10-21T18:28:17Z Files modified: * raddb/sites-available/inner-tunnel Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/4c465da10b8e51e30fc3… ====== Changed cui policy. Changed the updating of the cui in the database to occur in the cui.post-auth. Changed mods-available/cui module name Scott Armitage@2012-10-21T18:19:37Z Files modified: * raddb/mods-available/cui * raddb/policy.d/cui Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/fdb47b332087bacc5f1b… ====== Changed cui policy. Added settings to (optionally) make requirement of operator name a pre-requisite for cui generation Scott Armitage@2012-10-21T17:58:19Z Files modified: * raddb/policy.d/cui Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/785950755dab19fa7dd3… ====== Changed cui policy. Added a cui.pre-proxy section to request a cui when proxying authentication requests Scott Armitage@2012-10-21T17:39:54Z Files modified: * raddb/policy.d/cui Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/a8bca3528c18c4e92cec… ====== Changed cui policy. cui.authorize requires a flag is set in client definition. This allows cui request on a per client basis Scott Armitage@2012-10-21T17:28:23Z Files modified: * raddb/policy.d/cui Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/69887993251e529347d6… ====== Added the cui hash to cui policy Scott Armitage@2012-10-21T17:20:13Z Files modified: * raddb/policy.d/cui Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/92ec137fd5a6d4ef8b08… ====== Minor formatting fixes Arran Cudbard-Bell@2012-10-21T18:58:18Z Files modified: * src/include/libradius.h Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/68040809e841ad745185… ====== -- This commit summary was generated @2012-10-22T18:00:02Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0

Commit report for master branch
by announce＠freeradius.org 21 Oct '12

21 Oct '12

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== Made packet data len "size_t". Only one place needs it to be negative: the read from the socket. For the rest of the code, it is ALWAYS positive. As part of this, changed a few other variables, too. And uses "%zu" for printing "size_t" variables. C99 is everywhere. If you want to build the server on a non-C99 compiler, go away. Alan T. DeKok@2012-10-20T09:40:01Z Files modified: * src/include/libradius.h * src/lib/radius.c * src/lib/tcp.c * src/lib/vqp.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/41ae75bf88f17769e6da… ====== Fix compiler warnings Alan T. DeKok@2012-10-20T09:26:22Z Files modified: * src/lib/radius.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/941631859bad00ebfe8d… ====== Merge branch 'master' of github.com:FreeRADIUS/freeradius-server Alan T. DeKok@2012-10-20T09:05:41Z Files modified: * src/include/Makefile * src/include/all.mk * src/include/base64.h * src/include/libradius.h * src/include/radiusd.h * src/lib/Makefile * src/lib/all.mk * src/lib/base64.c * src/lib/dhcp.c * src/lib/radius.c * src/main/command.c * src/main/xlat.c * src/modules/rlm_expr/rlm_expr.c * src/modules/rlm_ldap/rlm_ldap.c * src/modules/rlm_python/prepaid.py * src/modules/rlm_python/radiusd.py * src/modules/rlm_python/rlm_python.c * src/modules/rlm_sql/rlm_sql.c * src/modules/rlm_cache/rlm_cache.c * src/modules/rlm_sql/drivers/rlm_sql_mysql/all.mk.in Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/995cfe29007eb98d52dc… ====== -- This commit summary was generated @2012-10-20T18:00:01Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

3 2

Commit report for v2.1.x branch
by announce＠freeradius.org 18 Oct '12

18 Oct '12

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== Substitute 'signature' for 'Request Authenticator' or 'Response Authenticator' where appropriate Arran Cudbard-Bell@2012-10-18T12:39:42Z Files modified: * src/lib/radius.c * src/main/command.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/d7ade8e9e66bbb81ed1d… ====== -- This commit summary was generated @2012-10-18T18:00:01Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0

Commit report for master branch
by announce＠freeradius.org 18 Oct '12

18 Oct '12

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== Substitute 'signature' for 'Request Authenticator' or 'Response Authenticator' where appropriate Arran Cudbard-Bell@2012-10-18T12:47:48Z Files modified: * src/lib/radius.c * src/main/command.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/5dd1011b786da4f59fac… ====== -- This commit summary was generated @2012-10-18T18:00:01Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0

problem with radclient
by Vladimir Grujić 18 Oct '12

18 Oct '12

Hi, I have the following setup: freeradius is compiled with udpfromto. The reason is that advertised public service address is on lo:1 interface (because the freeradius is behind load balancer in routed mode not in nat mode). There is also another public ip on the eth interface to receive packets from the load balancer. The freeradius itself works well in that setup. The problem is radclient. When i send the packet of type COA-Disconnect to the nas using Packet-Src-IP-Address in the request with the value of lo:0 public ip address to terminate the user session i get this response: rad_recv: Disconnect-ACK packet from host 1.1.1.1 port 3799, id=110, length=43 rad_verify: Received Disconnect-ACK packet from home server 1.1.1.1 port 3799 with invalid signature! (Shared secret is incorrect.) radclient: no response from server for ID 110 socket 3 user is disconnected properly but radclient does not recognize that response ( I've used just -r 1 in this case, when using -r 3 i see additional packets sent but they of course get a Disconnect-NAK) i traced the communication and only one packet send and one is received. Looks like the problem is in the logic of rad_verify function when using Packet-Src-IP-Address. Thanks, Vladimir

5 14