- Freeradius-Devel - lists.freeradius.org

radiusclient minor memleak
by Alex Massover 21 Mar '10

21 Mar '10

Hi, If secret string is defined in radiusclient.conf like following: acctserver localhost:1646:mysecret (and not in 'servers' file - which btw is better way because 'servers' file is rereaded for every request), it leaks, because serv->secret is never freed. -- Best Regards, Alex Massover VoIP R&D TL Jajah Inc. This mail was sent via Mail-SeCure System.

1 0

freeradius-client wrapping gethostby*
by Alex Massover 17 Mar '10

17 Mar '10

Hi, In freeradius-client gethostby* is wrapped in order to be thread-safe. But imho it's done in wrong way causing gethostby* to malfunction. In lib/ip_util.c: _______________________________________________ size_t hostbuflen; char *tmphostbuf; int res; int herr; hostbuflen = 1024; tmphostbuf = malloc(hostbuflen); #endif #endif #ifdef GETHOSTBYNAME_R #if defined (GETHOSTBYNAMERSTYLE_GNU) while ((res = gethostbyname_r(hostname, &hostbuf, tmphostbuf, hostbuflen, &hp, &herr)) == ERANGE) { /* Enlarge the buffer */ hostbuflen *= 2; tmphostbuf = realloc(tmphostbuf, hostbuflen); } free(tmphostbuf); _______________________________________________ Afaik if tmphostbuf is freed the data is gone. The easiest way to fix it which I can think of is thread local storage (TLS), please see the patch. -- Best Regards, Alex Massover VoIP R&D TL Jajah Inc. This mail was sent via Mail-SeCure System.

2 2

radiusd died with an ASSERT in thread.c
by Hermann Lauer 17 Mar '10

17 Mar '10

Hello all, after running for a month or so one of my freeradius (2.1.8 with my latest vmps patch on debian lenny sparc) server died with an ASSERT in threads.c after logging a bunch of the appended messages. Is this somehow known or should I provide the complete config or something else ? For the moment I reduced the load of vqp queries to this server. Thanks for any help, Hermann ...about 40 of those omitted... Feb 3 17:30:27 femto freeradius[13978]: Discarding duplicate request from client sp4 port 55770 - ID: 91766 due to unfinished request 13802 Feb 3 17:30:27 femto freeradius[13978]: Discarding duplicate request from client sp4 port 55770 - ID: 91767 due to unfinished request 13803 Feb 3 17:30:27 femto freeradius[13978]: Discarding duplicate request from client sp4 port 55770 - ID: 91768 due to unfinished request 13804 Feb 3 17:30:27 femto freeradius[13978]: Discarding duplicate request from client sp4 port 55770 - ID: 91769 due to unfinished request 13805 Feb 3 17:30:27 femto freeradius[13978]: Discarding duplicate request from client sp4 port 55770 - ID: 91770 due to unfinished request 13806 Feb 3 17:30:27 femto freeradius[13978]: Discarding duplicate request from client sp4 port 55770 - ID: 91771 due to unfinished request 13807 Feb 3 17:30:27 femto freeradius[13978]: Discarding duplicate request from client sp4 port 55770 - ID: 91772 due to unfinished request 13808 Feb 3 17:33:38 femto freeradius[13978]: Discarding duplicate request from client sp4 port 52864 - ID: 26294 due to unfinished request 13809 Feb 3 17:33:39 femto freeradius[13978]: Discarding duplicate request from client sp4 port 52864 - ID: 26294 due to unfinished request 13809 Feb 3 17:33:40 femto freeradius[13978]: Discarding duplicate request from client sp4 port 52864 - ID: 26294 due to unfinished request 13809 Feb 3 17:35:28 femto freeradius[13978]: ASSERT FAILED threads.c[406]: (*request)->magic == REQUEST_MAGIC P.S.: Posted this accindentely 2 times to the users list where it's probably still waiting for approval, those can be deleted -- Netzwerkadministration/Zentrale Dienste, Interdiziplinaeres Zentrum fuer wissenschaftliches Rechnen der Universitaet Heidelberg IWR; INF 368; 69120 Heidelberg; Tel: (06221)54-8236 Fax: -5224 Email: Hermann.Lauer(a)iwr.uni-heidelberg.de

2 1

how to add vendor-specific h323-conf-id
by Tihomir Culjaga 11 Mar '10

11 Mar '10

hello, maybe it is a stupid question but i cannot figure that out.... i need to add h323-conf-id and i'm doing it like this but it keeps failing. if (rc_avpair_add(rh, &send, 24, "12345678-12345678-12345678", -1, 9) == NULL){ printf("An Error occured during rc_avpair_add : VSA h323-conf-id\n"); result = ERROR_RC; break; } I've added an $INCLUDE dictionary.cisco to the end of the default freeradius dictionary so the attribute should be known .. but still .. same problem Please, can someone help ?

1 0

GIT Log for 2010-03-10 00:33 GMT
by aland＠deployingradius.com 10 Mar '10

10 Mar '10

commit fc069010ffcc189e141d70f9f3a6b62b4394bd20 Author: Alan T. DeKok <aland(a)freeradius.org> Date: Tue Mar 9 10:12:01 2010 +0100 Check for closed sockets. This allows the module to continue if the DB suddenly disappears src/modules/rlm_sql/sql.c | 20 +++++++++++--------- 1 files changed, 11 insertions(+), 9 deletions(-)

1 0

a patch about rlm_sql
by zhongwei feng 09 Mar '10

09 Mar '10

hi, all: When radiusd is running, shutdown the oracle server, then occur "segment fail". [root@RADSERVER1 rlm_sql]# diff -u sql.c.orig sql.c --- sql.c.orig 2010-03-09 14:49:01.000000000 +0800 +++ sql.c 2010-03-09 14:49:48.000000000 +0800 @@ -507,7 +507,7 @@ /* * If there's no query, return an error. */ - if (!query || !*query) { + if (!query || !*query || !sqlsocket || !sqlsocket->conn) { return -1; } @@ -552,7 +552,7 @@ /* * If there's no query, return an error. */ - if (!query || !*query) { + if (!query || !*query || !sqlsocket || !sqlsocket->conn) { return -1; } 　

2 1

GIT Log for 2010-03-07 00:33 GMT
by aland＠deployingradius.com 07 Mar '10

07 Mar '10

commit f26f41c0ee6c562200f4aedbe55bdf083a36bb1b Author: Alan T. DeKok <aland(a)freeradius.org> Date: Sat Mar 6 15:45:08 2010 +0100 Allow IPv6 to bind to interface with scope. A follow-on to the previous patch. Files changed: src/main/listen.c | 52 +++++++++++++++++++++++++++++++++++++++++++--------- 1 files changed, 43 insertions(+), 9 deletions(-) ====================================================================== commit 5b1ad1b0d1314c00499833126943f53aa36318a7 Author: Alan T. DeKok <aland(a)freeradius.org> Date: Sat Mar 6 14:26:27 2010 +0100 Add IPv6 "scope" for link-local addresses. Added to fr_ipaddr_t. fr_ipaddr_cmp(), fr_sockaddr2ipaddr(), fr_ipaddr2sockaddr(). Also made ip_hton() call fr_sockaddr2ipaddr() to prevent code duplication. Files changed: src/include/libradius.h | 1 + src/lib/misc.c | 59 ++++++++++++++++++++--------------------------- 2 files changed, 26 insertions(+), 34 deletions(-) ====================================================================== commit 882a4146bd8ed61b1d2044e53744678c209e7343 Author: Alan T. DeKok <aland(a)freeradius.org> Date: Sat Mar 6 12:40:23 2010 +0100 Check for AF_INET6, not HAVE_AF_INET6 HAVE_AF_INET6 isn't defined, AF_INET6 is. Files changed: src/lib/udpfromto.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) ====================================================================== commit b3a5a8a4dcd123c5b1f926599c5a2cadb08eee11 Author: Alan T. DeKok <aland(a)freeradius.org> Date: Sat Mar 6 12:13:54 2010 +0100 Work around implementation-dependent shift results uint32 foo = ~0; foo <<= 32; Q: what's foo? A: undefined. Files changed: src/main/client.c | 13 +++++++++---- 1 files changed, 9 insertions(+), 4 deletions(-) ====================================================================== commit 37c5fd7964811f39ba366f80947226dadb5b5a5e Author: Alan T. DeKok <aland(a)freeradius.org> Date: Sat Mar 6 11:03:33 2010 +0100 Calculate IPv6 netmask correctly. Closes bug #69 Files changed: src/main/client.c | 26 ++++++++++++++++++++------ 1 files changed, 20 insertions(+), 6 deletions(-) ====================================================================== commit 4d849cc53763e28972ecddea79afed016968d6fc Author: Alan T. DeKok <aland(a)freeradius.org> Date: Sat Mar 6 08:48:06 2010 +0100 Receive CoA packets when they have been separated from parents Otherwise, the code thinks that there is a proxy reply WITHOUT an original reply.. There's still likely a bug, as the CoA request->reply is built BEFORE the original->reply. The post-proxy CoA work should very likely have complete access to the original reply packet type Files changed: src/main/event.c | 12 ++++++++++++ 1 files changed, 12 insertions(+), 0 deletions(-) ====================================================================== commit c8a5624e1f5ea71b564f626337c56b8cfd86a775 Author: Alan T. DeKok <aland(a)freeradius.org> Date: Fri Feb 26 11:11:02 2010 +0100 Clean up log file handling. Fixes bug #63 We now open the log file from the option parsing (-l file) OR in mainconfig.c. That way, the code in log.c can assume that there is ALWAYS a log file, and it doesn't need to open one. This simplifies log.c substantially. We also moved the syslog "openlog" code from log.c to mainconfig.c This again makes it simpler. On HUP, the hup_mainconfig() function takes care of re-opening the log file. This is so that the log.c functions don't have to do it. Files changed: src/main/event.c | 12 ++----- src/main/mainconfig.c | 82 ++++++++++++++++++++++++++++++++++++++++++------ src/main/radiusd.c | 7 +++- 3 files changed, 80 insertions(+), 21 deletions(-) ====================================================================== commit 9a6edfe42404bb0532a24927cb20180444fd42d0 Author: Alan T. DeKok <aland(a)freeradius.org> Date: Fri Feb 26 10:31:59 2010 +0100 As posted to the list Files changed: share/dictionary.hp | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) ====================================================================== commit 243f3497ed43ba8b3a2ad340c5a3a1e25b03be9b Author: Alan T. DeKok <aland(a)freeradius.org> Date: Tue Feb 16 17:47:27 2010 +0100 Switch default for acct realms to "no_response_fail" Since accounting packets aren't re-tried, failing one packet over from one server to another isn't a good idea. Files changed: src/main/realms.c | 16 ++++++++++++++++ 1 files changed, 16 insertions(+), 0 deletions(-) ======================================================================

1 0

radiusclient thread-safety
by Alex Massover 02 Mar '10

02 Mar '10

Hello, I'm using radiusclient lib from multithreaded application, by having a "static rc_handle *rh" and calling rc_auth() from different threads. Everything works until 2 (or more) threads enter rc_auth() before the previous one finished. But 2 concurrent threads enough to corrupt everything, I'm starting to get "received invalid reply digest..." followed by "no reply from RADIUS server" for subsequent calls. I changed rc_check_reply() to return OK at the beginning, it eliminated "received invalid reply", but I still get "no reply from RADIUS server ...". In wireshark trace it looks like there's no problems with responses, every request receives response (and before timeout should happen). It looks like something logical, shared or static buffer maybe. I'm looking in the code and can't find the problem :( I changed localtime to localtime_r, gmtime to gmtime_r, rand to rand_r, but still have a problem. In the trace: ->request <-response ->request <-response Works well, but looks like enough to have: ->request ->request <-response <-response To cause most of (not every) following subsequent request to get "no reply..." although there're responses in the trace. Also my distro has old radiusclient-ng and not freeradiusclient, but as far as I understood there's no difference in this section. Can someone enlighten me on the subj please? -- BR, Alex. This mail was sent via Mail-SeCure System.

2 12

HP dictionary update (HP-Capability-Advertisement)
by Arran Cudbard-Bell 26 Feb '10

26 Feb '10

Hi All, New attribute available in K.14. and T branch switches. Please see wiki for details (http://wiki.freeradius.org/HP#Capability_advertisements) These were really designed for the ProCurve HP IDM product, but they might still be useful in some environments. The encoding scheme isn't documented in any manuals but the attributes existence is. HP ProCurve is committed to interoperability and open standards, they just aren't always terribly good at documenting the technical aspects of their features. Cheers, Arran

2 2

question about 1.1.6 client code: rc_config_init()
by Adam Lewis 18 Feb '10

18 Feb '10

Hi, I'm currently trying to use the 1.1.6 client code to create an embedded client. Doing a code inspection of rc_config_init() in lib\config.c , the following code looks suspicious: SERVER *authservers; SERVER *acctservers; ..... ..... authservers = rc_conf_srv(rh, "authserver"); acctservers = rc_conf_srv(rh, "acctserver"); authservers = malloc(sizeof(SERVER)); acctservers = malloc(sizeof(SERVER)); I think it's trying to malloc space for server options in rh but this doesn't happen. The net result is that any subsequent configuration of authservers and acctservers in this function will be lost as soon as the function is exited. Likewise the mallocs can never be freed up. Have I understood this correctly? Not sure how fixes get put back into the code for the next release. If someone can let me know if there is a formal procedure, that would be great. Cheers, Adam. -- View this message in context: http://old.nabble.com/question-about-1.1.6-client-code%3A-rc_config_init%28… Sent from the FreeRadius - Dev mailing list archive at Nabble.com.

2 2