- Freeradius-Devel - lists.freeradius.org

..::Juniper Accounting issue::..
by Alfonso Alejandro Reyes Jimenez 16 Feb '10

16 Feb '10

Hi Everyone. I'm writing to this list because I'm having issues with the accounting part on the radius server. The main idea is to log every command that we apply to the firewall. Right now we can log in to the device with different profiles but we are not logging the authentication time or the disconnection time. if we use the radius client (ntradping) we log everything. We have all the configuration setup on the firewall side but we are not sure if we are setting up everything on the radius. We are using the following values for the user: steve Cleartext-Password := "testing" NS-Admin-Privilege = 2, NAS-IP-Address = 192.168.1.1, NAS-Identifier = "Juniper" Are we missing something? Is it possible to log every command that we apply to the firewall? Any ideas? Thanks in advance for everything. Regards. Alfonso.

1 0

how to use mysql existing connection in c code
by Vijay Badola 15 Feb '10

15 Feb '10

Can I use mysql connection, created by server initially by reading sql.conf, from my own separate module to get sql query answer? pls tell me how to use it in C code from own separate module. , Regards Vijay

2 1

GIT Log for 2010-02-12 00:33 GMT
by aland＠deployingradius.com 12 Feb '10

12 Feb '10

commit 4545d8ecd41cd798efc2fd75d86826c4f0e3fd40 Author: Alan T. DeKok <aland(a)freeradius.org> Date: Thu Feb 11 12:44:24 2010 +0100 Added sample CoA server Files changed: raddb/sites-available/coa | 43 +++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 43 insertions(+), 0 deletions(-) ====================================================================== commit d191c9da828bfd84660026ec38dac29d5b49ec08 Author: Alan T. DeKok <aland(a)freeradius.org> Date: Thu Feb 11 10:38:20 2010 +0100 Make it consisent with the example in decoupled-accounting Files changed: raddb/sites-available/buffered-sql | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) ====================================================================== commit dd81dc720694b59ac12cd5368470467df9b46f60 Author: Alan T. DeKok <aland(a)freeradius.org> Date: Thu Feb 11 10:36:51 2010 +0100 As posted to the list Files changed: share/dictionary.patton | 25 +++++++++++++++++++++++++ 1 files changed, 25 insertions(+), 0 deletions(-) ====================================================================== commit 4422b0357c8e8e12a8e2e2254a279b9245ef1473 Author: Alan T. DeKok <aland(a)freeradius.org> Date: Thu Feb 11 10:36:26 2010 +0100 Ran it through the formatter. Files changed: share/dictionary.patton | 196 +++++++++++++++++++++++----------------------- 1 files changed, 98 insertions(+), 98 deletions(-) ====================================================================== commit 359088a1c13a51c0f04eae63463a3f6762c8cb1d Author: Alan T. DeKok <aland(a)freeradius.org> Date: Thu Feb 11 10:33:19 2010 +0100 Add more information to warning message Component && module, if a child thread is stuck for a long time. Files changed: src/main/event.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) ====================================================================== commit 11b86ed0082ea8c46c4b094cda81663e4d8d49fd Author: Alan T. DeKok <aland(a)freeradius.org> Date: Thu Feb 11 10:41:29 2010 +0100 Function returns no value Files changed: src/main/event.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) ====================================================================== commit 7b4b345cb246300633af3a5461478810f9affa2e Author: Alan T. DeKok <aland(a)freeradius.org> Date: Thu Feb 11 10:32:20 2010 +0100 Quiet compiler warnings Files changed: src/lib/event.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) ====================================================================== commit d6cc04ec5ec2eae5fcdc2f52683034b1715f2255 Author: Alan T. DeKok <aland(a)freeradius.org> Date: Thu Feb 11 10:24:57 2010 +0100 Do waitpid() for ALL children, even if there are no threads waiting i.e. call radius_exec_program() 4 times for each packet, each with "nowait". The "reap_children" function is called ONCE per packet, and was calling waitpid() ONCE if there were no threads waiting for a child. This change makes it KEEP waiting until there are no more children to wait for. Files changed: src/main/threads.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) ======================================================================

1 0

buffer overflow in radiuslient
by Dmitry Goncharov 09 Feb '10

09 Feb '10

Hi, I opened two bug reports https://bugs.freeradius.org/bugzilla/show_bug.cgi?id=60 https://bugs.freeradius.org/bugzilla/show_bug.cgi?id=61 and provided patches. Please, have a look. BR, Dmitry

1 0

Wish list
by Account for FreeRadius mail list 07 Feb '10

07 Feb '10

Hello All, Well after doing a upgrade from ver 1.3 to 2.0 (Debian upgrade to Lenny) and much time spent I got this thing working as it should. In the proxy.conf file I found the thing that was causing me problems. It was a realm statement "notrealm" that caused that particular realm not to load. It would be real nice in the log file that it did not just say: "Info: Ready to process requests." but it told you that it could not load a particular realm because of an error. I know this can be kind of nit picking and don't get me wrong I very much appreciate what everyone has done for this code, but it would save a lot of time trying to figure out where "I" screwed up at. Thanks, Ken

2 1

buffered-sql patch
by Ben Wiechman 05 Feb '10

05 Feb '10

Minor update to the detail filename to make it consistent with the example in decoupled-accounting. Ben

1 0

GIT Log for 2010-02-05 00:33 GMT
by aland＠deployingradius.com 05 Feb '10

05 Feb '10

commit 30c03d55e0e587777b043174c78b76461ba4bde5 Author: Alan T. DeKok <aland(a)freeradius.org> Date: Thu Feb 4 18:09:22 2010 +0100 Fixes to build without TCP Files changed: src/lib/packet.c | 9 +++++++++ src/main/client.c | 6 +----- src/main/event.c | 17 +++++++++++++++-- 3 files changed, 25 insertions(+), 7 deletions(-) ====================================================================== commit fc8b4513c6dc367339651663c0ce2db1f04691ce Author: Alan T. DeKok <aland(a)freeradius.org> Date: Thu Feb 4 08:50:37 2010 +0100 Added note on global CA Files changed: raddb/eap.conf | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) ====================================================================== commit efa03059b2be34253a3ada47f00b12216bbdbe38 Author: Alan T. DeKok <aland(a)freeradius.org> Date: Thu Feb 4 08:45:12 2010 +0100 Make MS-CHAP call xlat on NT-Hash and LM-Password This moves the "expand variable" code to the correct place. Files changed: src/modules/rlm_mschap/rlm_mschap.c | 29 +++++++++++++++++++++++------ src/modules/rlm_pap/rlm_pap.c | 7 +++---- 2 files changed, 26 insertions(+), 10 deletions(-) ====================================================================== commit 98292c0e3010bd9123a8afbea04ba80edce3e5c8 Author: Alan T. DeKok <aland(a)freeradius.org> Date: Sat Jan 23 10:08:55 2010 +0100 in pairmake_any(), value may be NULL Files changed: src/lib/valuepair.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) ====================================================================== commit e0308aed7c6537d26b6c7a3bced88370c0baa8be Author: Alan T. DeKok <aland(a)freeradius.org> Date: Sat Jan 23 09:05:21 2010 +0100 As posted to the list Files changed: share/dictionary | 1 + share/dictionary.wichorus | 16 ++++++++++++++++ 2 files changed, 17 insertions(+), 0 deletions(-) ====================================================================== commit 7fe7b2acf923345f8893c034a0d2cf3a19d54f45 Author: Alan T. DeKok <aland(a)freeradius.org> Date: Fri Jan 22 13:40:30 2010 +0100 Added more 'const', and changed stats to %u Some tests showed that the stats went over 2^31... and then they went negative Files changed: src/modules/frs_control/frs_control.c | 32 ++++++++++++++++---------------- 1 files changed, 16 insertions(+), 16 deletions(-) ====================================================================== commit 1eb5a9f3fd373a5758209d093b33f229b2613072 Author: Alan T. DeKok <aland(a)freeradius.org> Date: Fri Jan 22 13:40:16 2010 +0100 Added more 'const' Files changed: src/include/conffile.h | 8 ++++---- src/main/conffile.c | 10 +++++----- 2 files changed, 9 insertions(+), 9 deletions(-) ====================================================================== commit 21a4dcaebba1596c3eb67e2a629c28883ede11a0 Author: Alan T. DeKok <aland(a)freeradius.org> Date: Fri Jan 22 10:41:46 2010 +0100 Set flag CORRECTLY for resumed session Files changed: src/modules/rlm_eap/libeap/eap_tls.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) ====================================================================== commit 595657f053d7ceb5bb34c96156ed1f9279fbb05c Author: Alan T. DeKok <aland(a)freeradius.org> Date: Thu Jan 21 11:37:21 2010 +0100 Add statistics for detail listeners, too Files changed: src/include/detail.h | 3 + src/modules/frs_control/frs_control.c | 69 +++++++++++++++++++++++++++++++++ src/modules/frs_detail/frs_detail.c | 10 +++++ 3 files changed, 82 insertions(+), 0 deletions(-) ====================================================================== commit 174f0f675c30b9e50831f8e86029307b0625e621 Author: Alan T. DeKok <aland(a)freeradius.org> Date: Thu Feb 4 08:59:53 2010 +0100 Check for allocation failure Files changed: src/main/util.c | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) ====================================================================== commit 4c18f64d826006a452aff6ef18a8904d88d534c2 Author: Alan T. DeKok <aland(a)freeradius.org> Date: Thu Feb 4 08:57:26 2010 +0100 Print the request number on every log line. Files changed: src/main/log.c | 7 ++++++- 1 files changed, 6 insertions(+), 1 deletions(-) ====================================================================== commit b4093cf1fb4d8fd09b7bbafae8838a5368c93b99 Author: Alan T. DeKok <aland(a)freeradius.org> Date: Thu Feb 4 08:55:43 2010 +0100 More useful errors track total number of open sockets, and print "too many sockets" if there are too many Files changed: src/lib/packet.c | 18 ++++++++++++++++-- 1 files changed, 16 insertions(+), 2 deletions(-) ======================================================================

1 0

Re: [trivial PATCH 11/22] [extern.h] eliminate build warnings
by WANG Tinggong 04 Feb '10

04 Feb '10

Frank Cusack wrote: >This applies to patches 11-16. > >Having these be individual unrelated patches is very annoying. It's >very difficult to review because the change in prototype is not in >the same change as the change to the functions. So I haven't done >a thorough job, but for once I am going to blame the author instead >of my own laziness. > >This just looks like churn to me. You change the types of vars from >char to unsigned char, but then cast them back when they are used. > >In at least 2 cases where I caught it, the change in var type is >incorrect and you are just making a trivial change without understanding >the effects other than to quiet the compiler on your system. Yes, that is my original intention. I clone the branch and compile it, after my compiler show warnings to me, i just submit these patches without a moment's thought and it's too impetuous. > >There may be at least one change that was correct, and that would only >have been the case if a radius structure member changed its signedness. >Because of the difficulty of reviewing the changes I'm not going >to try to go back and pick out where I thought that might have >been the case. > >I have in the past been extremely diligent about not having any >compiler warnings so I'm surprised that rlm_otp is generating any >noise. There must be one member in a radius struct somewhere that >changed and that is filtering down. In my opinion, a compiler warning may led to a potentional bug, for example, int a = -1; unsigned int b = 1; (a > b) ? printf("yes") : printf("no"); then compiler tell us "warning: comparison between signed and unsigned", if we ignore it, then -1 > 1, that's not expected. so i'm accustomed to fix all warning. thanks for your review! Tinggong

2 1

pam_radius_auth on Mac OS 10.6.2 - patch attached
by Stefan Winter 04 Feb '10

04 Feb '10

Hi, to my own surprise, I got pam_radius_auth 1.3.17 compiled and running on Mac OS X 10.6.2. It needed some minor source code changes and guesswork in the Makefile. I've attached a patch which shows the difference. The new Makefile will then have a new target make mac Please review the patch - especially where entropy in the random number generater is reduced. Greetings, Stefan Winter

3 6

Build error with -DWITHOUT_TCP
by WANG Tinggong 04 Feb '10

04 Feb '10

Hi all, After add -DWITHOUT_TCP flag in src/main/Makefile: CFLAGS += -DWITHOUT_TCP I got an error: client.c: In function 'client_find_old': client.c:498: error: too few arguments to function 'client_find' I fixed it with a patch below and compiled it again, more errors show up. event.c:635: warning: no previous prototype for 'revive_home_server' event.c:853: warning: no previous prototype for 'mark_home_server_dead' event.c: In function 'event_new_fd': event.c:3453: error: 'rad_listen_t' has no member named 'count' event.c:3455: error: 'remove_all_requests' undeclared (first use in this function) event.c:3455: error: (Each undeclared identifier is reported only once event.c:3455: error: for each function it appears in.) event.c:3458: error: 'rad_listen_t' has no member named 'count' event.c:3465: error: 'rad_listen_t' has no member named 'count' event.c:3483: error: 'rad_listen_t' has no member named 'count' event.c:3486: error: 'remove_all_proxied_requests' undeclared (first use in this function) event.c:3488: error: 'rad_listen_t' has no member named 'count' event.c:3544: error: 'rad_listen_t' has no member named 'count' event.c:3560: error: 'rad_listen_t' has no member named 'count' event.c:3582: error: 'listen_socket_t' has no member named 'ev' event.c:3600: error: 'rad_listen_t' has no member named 'count' event.c:3636: error: 'listen_socket_t' has no member named 'ev' event.c:3636: error: 'listen_socket_t' has no member named 'ev' event.c: In function 'handle_signal_self': event.c:3732: error: 'tcp_socket_lifetime' undeclared (first use in this function) event.c:3737: error: 'tcp_socket_idle_timeout' undeclared (first use in this function) event.c:3741: error: 'listen_socket_t' has no member named 'ev' make: *** [event.lo] Error 1 I've fetched the newest stable tree, what's wrong? Here is the patch for client.c:498: error: too few arguments to function 'client_find' thanks Tinggong --- diff --git a/src/main/client.c b/src/main/client.c index 247ce1d..596b09e 100644 --- a/src/main/client.c +++ b/src/main/client.c @@ -489,14 +489,17 @@ RADCLIENT *client_find(const RADCLIENT_LIST *clients, /* * Old wrapper for client_find */ +#ifdef WITH_TCP RADCLIENT *client_find_old(const fr_ipaddr_t *ipaddr) { - return client_find(root_clients, ipaddr -#ifdef WITH_TCP - , IPPROTO_UDP -#endif - ); + return client_find(root_clients, ipaddr, IPPROTO_TCP); +} +#else +RADCLIENT *client_find_old(const fr_ipaddr_t *ipaddr) +{ + return client_find(root_clients, ipaddr, IPPROTO_UDP); } +#endif static struct in_addr cl_ip4addr; static struct in6_addr cl_ip6addr; -- 1.6.0.6

2 2